Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error:Space not found for xxx #2480

Closed
wants to merge 1 commit into from

Conversation

tong-hao
Copy link
Contributor

@tong-hao tong-hao commented Jun 1, 2021

What changes were proposed in this pull request?

fix bug: Space not found on console.

Why are the changes needed?

I execute 'use space' on console. It's Space not found.

step1: Space has created. And IP 106 is meta leader.
step2: Restart graphd(IP 105). graphd(105) connects a metad follower(107)
Jietu20210528-100605

step3: using console to connect graphd(105). type 'use finance'.
image

step4: There are 'space not found'. Then I execute 'show spaces' and 'use finance'. It‘s success.

Reason: MetaClient cannot get a LEADER_CHANGED response code.

Will break the compatibility? How if so?

no

Does this PR introduce any user-facing change?

no

How was this patch tested?

  1. start metad、storaged、graphd
  2. create space.
  3. restart graphd.
  4. execute "use space_name" on console.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above
  • I've informed the technical writer about the documentation change if necessary

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tong-hao tong-hao changed the title fixed for space not found. fix error:Space not found for xxx Jun 1, 2021
@tong-hao tong-hao marked this pull request as ready for review June 1, 2021 08:42
@laura-ding
Copy link
Contributor

@tong-hao Thank you for your contribution, in fact, there are a lot of all is the same problem, 2.0 have changed, you may have a look this pr vesoft-inc/nebula-storage#423. 1.0 we do not do temporarily change, If you are interested, can you change it together?

@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Sep 13, 2021
@Sophie-Xie Sophie-Xie closed this Sep 27, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants